Repository navigation
Conversation
tamird
force-pushed
the
rules-img-basic-images
branch
2 times, most recently
from
October 22, 2026 14:07
1d562c4 to
3987e82
Compare
aaltinaydev
approved these changes
Oct 22, 2026
tamird
force-pushed
the
rules-img-basic-images
branch
from
October 24, 2026 02:26
3987e82 to
c278666
Compare
copybara-service Bot
pushed a commit
that referenced
this pull request
Oct 24, 2026
Assemble Alpine, BusyBox and the tmpfile fixture as Bazel image targets so workers can build and cache them without a Docker daemon. Pin both architecture variants of the existing base images and declare the fixture file as a layer input. Connect the resulting archives to the existing Make image targets. Hash the assembled archive before looking up cached images so changes to transitive Bazel inputs invalidate the image tag. Preserve the image names consumed by tests and the existing registry push/load interface. Assisted-by: Codex Auto-fixed-by: [🤖] @EtiennePerot FUTURE_COPYBARA_INTEGRATE_REVIEW=#16097 from tamird:rules-img-basic-images c278666 PiperOrigin-RevId: 1006038426
copybara-service Bot
pushed a commit
that referenced
this pull request
Oct 24, 2026
Assemble Alpine, BusyBox and the tmpfile fixture as Bazel image targets so workers can build and cache them without a Docker daemon. Pin both architecture variants of the existing base images and declare the fixture file as a layer input. Connect the resulting archives to the existing Make image targets. Hash the assembled archive before looking up cached images so changes to transitive Bazel inputs invalidate the image tag. Preserve the image names consumed by tests and the existing registry push/load interface. Assisted-by: Codex Auto-fixed-by: [🤖] @EtiennePerot FUTURE_COPYBARA_INTEGRATE_REVIEW=#16097 from tamird:rules-img-basic-images c278666 PiperOrigin-RevId: 1006038426
Assemble Alpine, BusyBox and the tmpfile fixture as Bazel image targets so workers can build and cache them without a Docker daemon. Pin both architecture variants of the existing base images and declare the fixture file as a layer input. Stage each image archive before Make looks up its tag, so changes to transitive inputs invalidate the cache. Use the same staging rule for the CUDA images, which need the shared helper context. Preserve the image names and registry targets used by tests and CI.
tamird
force-pushed
the
rules-img-basic-images
branch
from
October 24, 2026 10:44
c278666 to
781d64d
Compare
Contributor
Author
|
@aaltinaydev, could you re-approve 781d64d? I resolved the Make Both architecture builds and the three AMD64 container smoke tests Posted by Codex on behalf of @tamird. |
copybara-service Bot
pushed a commit
that referenced
this pull request
Oct 24, 2026
Assemble Alpine, BusyBox and the tmpfile fixture as Bazel image targets so workers can build and cache them without a Docker daemon. Pin both architecture variants of the existing base images and declare the fixture file as a layer input. Connect the resulting archives to the existing Make image targets. Hash the assembled archive before looking up cached images so changes to transitive Bazel inputs invalidate the image tag. Preserve the image names consumed by tests and the existing registry push/load interface. Assisted-by: Codex Auto-fixed-by: [🤖] @EtiennePerot FUTURE_COPYBARA_INTEGRATE_REVIEW=#16097 from tamird:rules-img-basic-images c278666 PiperOrigin-RevId: 1006038426
copybara-service Bot
pushed a commit
that referenced
this pull request
Oct 24, 2026
Assemble Alpine, BusyBox and the tmpfile fixture as Bazel image targets so workers can build and cache them without a Docker daemon. Pin both architecture variants of the existing base images and declare the fixture file as a layer input. Connect the resulting archives to the existing Make image targets. Hash the assembled archive before looking up cached images so changes to transitive Bazel inputs invalidate the image tag. Preserve the image names consumed by tests and the existing registry push/load interface. Assisted-by: Codex Auto-fixed-by: [🤖] @EtiennePerot COPYBARA_INTEGRATE_REVIEW=#16097 from tamird:rules-img-basic-images c278666 PiperOrigin-RevId: 1006446131
Collaborator
|
Merged in #16307 |
tamird
added a commit
to tamird/gvisor
that referenced
this pull request
Oct 27, 2026
Adding images/basic/BUILD made that directory a separate Bazel package, so images:sources no longer includes its files through the parent glob. Export those files explicitly and include them in images:source_contexts, preserving the Docker contexts that still live under images/basic. Both BUILD files match the corresponding approved google#16097 postimages. This restores the source export omitted from its imported change.
copybara-service Bot
pushed a commit
that referenced
this pull request
Oct 27, 2026
Adding images/basic/BUILD made that directory a separate Bazel package, so images:sources no longer includes its files through the parent glob. Export those files explicitly and include them in images:source_contexts, preserving the Docker contexts that still live under images/basic. Both BUILD files match the corresponding approved #16097 postimages. This restores the source export omitted from its imported change. FUTURE_COPYBARA_INTEGRATE_REVIEW=#16374 from tamird:restore-basic-image-source-contexts dc6c326 PiperOrigin-RevId: 1007671962
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assemble the Alpine, BusyBox and tmpfile test images with Bazel so
remote workers can build and cache them without a Docker daemon. Pin the
AMD64 and ARM64 variants of each base image and declare the tmpfile
fixture as a layer input.
Make computes each image tag from its build context. Stage the Bazel
archive before computing that tag so changes to the assembled image
invalidate the cache. The same rule stages the CUDA images’ shared
context, which contains their compiled helpers. Keep the image names and
registry targets used by tests and CI.